Limit simple search #6325
Merged
Limit simple search #6325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatsoulas
reviewed
Oct 31, 2024
smithellis
force-pushed
the
dont-display-archived-question
branch
from
c0b4c69 to
1ba7b20
Compare
escattone
reviewed
Dec 18, 2024
There was a problem hiding this comment.
@smithellis Have you tried testing this locally? When I run this branch locally, I stop getting any hits when making simple searches for known titles or keywords. I thought it was my setup at first, but when I switched to the main branch, my simple searches for known titles and keywords worked fine.
kitsune/search/search.py
Outdated
| @@ -124,6 +125,8 @@ def get_filter(self): | |||
| "gte": datetime.now(timezone.utc) - timedelta(days=QUESTION_DAYS_DELTA) | |||
| }, | |||
| ), | |||
| # don't return archived Questiosn | |||
There was a problem hiding this comment.
It's been a while, but yes I did test locally. I'll take another look. And fix the typo, too!
smithellis
force-pushed
the
dont-display-archived-question
branch
2 times, most recently
from
ff217bb to
b530b5e
Compare
Update search.py to exclude archived questions
smithellis
force-pushed
the
dont-display-archived-question
branch
from
b530b5e to
0e2101b
Compare
escattone
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit simple search - don't display archived Questions.