Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove waffle serving URL path #6223

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

smithellis
Copy link
Contributor

This early pattern is no longer needed.

@akatsoulas
Copy link
Collaborator

Why isn't this needed?

@smithellis
Copy link
Contributor Author

I'm not sure why it was ever there - I think the idea early on was to test some WT stuff at /wagtail, but we have not been doing that. When I asked @escattone about it a while back he agreed that it wasn't really serving a purpose right now.

@akatsoulas
Copy link
Collaborator

From what I recall, it was an extra mechanism to control whether WT is enabled in production. If this is the case, I would argue to keep it around until we are ready to go live

@smithellis
Copy link
Contributor Author

Just to note my thoughts here - we aren't using this right now, so I'd argue it doesn't need to be here. It only allows us to serve things at /wagtail and then only when a waffle flag is set. As far as I know, we are not planning to serve anything at /wagtail at the moment, nor do we use the waffle flag to control wagtail on/off. The login and/or CMS admin is not at /wagtail nor are any pages we are serving.
In another PR I have a more general setting WAGTAIL_ENABLE which does this.
I don't think it makes sense to have unused code (with no known future use) hanging around.

@smithellis smithellis self-assigned this Sep 20, 2024
@akatsoulas akatsoulas merged commit 2b5e42f into mozilla:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants