Update main menu navigation entries #6148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
akatsoulas
commented
Jul 26, 2024
akatsoulas
commented
- White label browse by topic macro.
- Convert slug to title filter
escattone
approved these changes
Jul 26, 2024
| <a href="{{ row_one_left_url }}" | ||
| data-event-name="link_click" | ||
| data-event-parameters='{ | ||
| "link_name": {{ link_name }}, |
There was a problem hiding this comment.
The {{ link_name }} needs to be wrapped in quotes on this one and all that follow.
Suggested change
| "link_name": {{ link_name }}, | |
| "link_name": "{{ link_name }}", |
* White label browse by topic macro. * Convert slug to title filter
akatsoulas
force-pushed
the
update-navigation-entries
branch
from
ff8c038
to
79d2fd3
Compare
|
thanks @escattone ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.