Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no longer needed workaround of sorting glob sets #271

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Remove no longer needed workaround of sorting glob sets #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/path_rewriting.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,6 @@ pub fn rewrite_paths(
) -> CovResultIter {
let mut glob_builder = GlobSetBuilder::new();

// workaround for bug: https://github.com/BurntSushi/ripgrep/issues/1079
// Some filters foo/* are ignored when not sorted
to_ignore_dirs.sort_unstable();

for to_ignore_dir in to_ignore_dirs {
glob_builder.add(Glob::new(&to_ignore_dir).unwrap());
}
Expand Down