Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1856730 - store debug values for session #1784

Merged

Conversation

rosahbruno
Copy link
Contributor

@rosahbruno rosahbruno commented Oct 4, 2023

Store the debug values set via window.Glean in sessionStorage which persists until the user closes the current tab.

I am not exactly sure what tests for this might look like. The only way to really write tests for this would be inside of BrowserStack, but to actually verify it works you need to see either console output or an entry in the debug ping viewer.

Doc updates - mozilla/glean#2638

Screen.Recording.2023-10-04.at.10.22.28.AM.mov

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@rosahbruno rosahbruno force-pushed the 1856730-persist-browser-debug-values branch from 52b0aa5 to 9cd3e8e Compare October 4, 2023 13:34
Store the debug values set via `window.Glean` in `sessionStorage` which
persists until the user closes the current tab.
@rosahbruno rosahbruno force-pushed the 1856730-persist-browser-debug-values branch from 9cd3e8e to dc206b0 Compare October 4, 2023 14:25
@rosahbruno rosahbruno marked this pull request as ready for review October 4, 2023 15:09
@auto-assign auto-assign bot requested a review from travis79 October 4, 2023 15:09
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, please be sure the behavior is documented in Glean docs

@rosahbruno rosahbruno merged commit bfa31db into mozilla:main Oct 6, 2023
7 of 8 checks passed
@rosahbruno rosahbruno deleted the 1856730-persist-browser-debug-values branch October 6, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants