Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix display of metrics after supporting labeled distributions #3016

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix display of metrics after supporting labeled distributions #3016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/config/glean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ export const FENIX = {
// This function is called directly after the response has been received by
// the frontend. It will always run, even against cached data, as a way of
// resetting the necessary state.
const viewType = probeType;
let etc = {};

// filter out true/false aggregate results in boolean metrics. See: https://github.com/mozilla/glam/pull/1525#discussion_r694135079
Expand All @@ -367,12 +368,12 @@ export const FENIX = {
data = data.filter((di) => di.client_agg_type === '');
}

if (probeType === 'categorical') {
if (viewType === 'categorical') {
etc = extractBucketMetadata(data);
appStore.setField('activeBuckets', etc.initialBuckets);
}

return { data, probeType, ...etc };
return { data, viewType, ...etc };
},
transformProbeForGLAM(probe) {
const pr = { ...probe };
Expand Down