Add Additional Delivery to Google Artifact Repo #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbanCloud
changed the title
corbanCloud
changed the title
whd
approved these changes
Nov 12, 2024
| # this could be done by re-tagging the existing image but for ease of migration | ||
| # I'm duplicating it fully with the intent of removing the above steps entirely | ||
| # /moz-fx-glam-prod/glam-prod/glam@sha256:705f53c5511c5803c6ea58896a93a97a30dc8defdef19c5d2243c3171a13be25 | ||
| - run: |
There was a problem hiding this comment.
Do you need to do this if you're just using the gcp-gcr orb? You're not actually using the GCP CLI after you set it up. It seems like you should be able to get away with a simpler config than this that's just gcp-gcr/build-and-push-image with the right environment variables set and with use_oidc set to true. But if this works then that's fine.
| image: auth0-proxy | ||
| tag: $CIRCLE_SHA1 | ||
|
|
||
| - gcp-gcr/push-image: |
There was a problem hiding this comment.
Has this been tested yet? I don't see any images in https://console.cloud.google.com/artifacts/docker/moz-fx-glam-prod/us/glam-prod?project=moz-fx-glam-prod other than the glam image.
Co-authored-by: whd <whd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GAR (Google Artifact Repository) as a second delivery source for GLAM images
Functionality was test in a temporary branch, which produced this artifact
The pipeline steps here are intentionally not DRY'd up between the existing GCR delivery as those steps can simply be deleted after V2 Migration is complete. Additionally GAR delivery was added for both the main glam app container and the auth0 proxy which creates some additional cruft during the transition