Enabling Marionette broken on Windows #640
Assignees
Milestone
Comments
andreastt
changed the title
andreastt
referenced
this issue
Apr 12, 2017
When a user provides a profile that wnats to override browser.warnOnQuit, browser.tabs.warnOnClose, or browser.showQuitWarning, we should allow users to do stupid things. We should not prevent the profile's preferences from being applied. dom.ipc.cpows.forbid-unsafe-from-browser is being removed because all targetted Firefoxen are not using any unsafe CPOWs in Marionette code. marionette.defaultPrefs.enabled is superfluous for as long as the --marionette flag is being passed to the Firefox binary. Remaining relevant prefs from prefs::REQUIRED have been merged into prefs::DEFAULT. This is a follow-up to the discussion around #423.
jgraham
pushed a commit
to jgraham/rust_mozrunner
that referenced
this issue
Apr 12, 2017
* runner: do not imply --marionette flag Users of mozrunner may not want to imply starting the Marionette remote control server when they start Firefox. This removes the --marionette flag from being inferred when building the command. It also addresses the issue that Windows systems do not understand double-dashed GNU style flags. I will later submit a patch to geckodriver which adds a single-dashed X11 style -marionette flag when calling mozrunner. Fixes: mozilla/geckodriver#640 * runner: use windows friendly -profile flag
jgraham
pushed a commit
that referenced
this issue
Apr 12, 2017
jgraham/rust_mozrunner#7 was recently submitted to make mozrunner not imply starting the Marionette server by passing the --marionette flag. This patch appends -marionette, with a single dash, so that it will be accepted on Windows systems. More discussion around this in 2e0054b. Fixes: #640
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
May 20, 2017
…ing browser jgraham/rust_mozrunner#7 was recently submitted to make mozrunner not imply starting the Marionette server by passing the --marionette flag. This patch appends -marionette, with a single dash, so that it will be accepted on Windows systems. More discussion around this in mozilla/geckodriver@2e0054b. Fixes: mozilla/geckodriver#640 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 7c577c04176c1cc7b5bd45928b3a36bd1818c5ae committer: jgraham <james@hoppipolla.co.uk> --HG-- extra : rebase_source : 44dda1287b2da1c8199bce149367ee5483f456e7
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this issue
May 21, 2017
…ing browser jgraham/rust_mozrunner#7 was recently submitted to make mozrunner not imply starting the Marionette server by passing the --marionette flag. This patch appends -marionette, with a single dash, so that it will be accepted on Windows systems. More discussion around this in mozilla/geckodriver@2e0054b. Fixes: mozilla/geckodriver#640 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 7c577c04176c1cc7b5bd45928b3a36bd1818c5ae committer: jgraham <james@hoppipolla.co.uk>
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this issue
May 25, 2017
…ing browser jgraham/rust_mozrunner#7 was recently submitted to make mozrunner not imply starting the Marionette server by passing the --marionette flag. This patch appends -marionette, with a single dash, so that it will be accepted on Windows systems. More discussion around this in mozilla/geckodriver@2e0054b. Fixes: mozilla/geckodriver#640 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 7c577c04176c1cc7b5bd45928b3a36bd1818c5ae committer: jgraham <james@hoppipolla.co.uk>
|
This issue has been automatically locked since there has not been any recent activity after it was closed. If you have run into an issue you think is related, please open a new issue. |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 1, 2019
…ing browser jgraham/rust_mozrunner#7 was recently submitted to make mozrunner not imply starting the Marionette server by passing the --marionette flag. This patch appends -marionette, with a single dash, so that it will be accepted on Windows systems. More discussion around this in mozilla/geckodriver@2e0054b. Fixes: mozilla/geckodriver#640 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 7c577c04176c1cc7b5bd45928b3a36bd1818c5ae committer: jgraham <jameshoppipolla.co.uk> UltraBlame original commit: 0663affcced9ec002c219ec077d62817c6a4ae9a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 1, 2019
…ing browser jgraham/rust_mozrunner#7 was recently submitted to make mozrunner not imply starting the Marionette server by passing the --marionette flag. This patch appends -marionette, with a single dash, so that it will be accepted on Windows systems. More discussion around this in mozilla/geckodriver@2e0054b. Fixes: mozilla/geckodriver#640 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 7c577c04176c1cc7b5bd45928b3a36bd1818c5ae committer: jgraham <jameshoppipolla.co.uk> UltraBlame original commit: 0663affcced9ec002c219ec077d62817c6a4ae9a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 1, 2019
…ing browser jgraham/rust_mozrunner#7 was recently submitted to make mozrunner not imply starting the Marionette server by passing the --marionette flag. This patch appends -marionette, with a single dash, so that it will be accepted on Windows systems. More discussion around this in mozilla/geckodriver@2e0054b. Fixes: mozilla/geckodriver#640 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 7c577c04176c1cc7b5bd45928b3a36bd1818c5ae committer: jgraham <jameshoppipolla.co.uk> UltraBlame original commit: 0663affcced9ec002c219ec077d62817c6a4ae9a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@juangj and I concluded in 2e0054b#commitcomment-21725614 that passing
--marionetteon Windows systems does not enable Marionette. Instead we must pass-marionette.The text was updated successfully, but these errors were encountered: