Skip to content

Commit

Permalink
Bug 1914054 [wpt PR 47697] - Fix dir=auto traversal to not apply elem…
Browse files Browse the repository at this point in the history
…ent-only rules to ancestors, a=testonly

Automatic update from web-platform-tests
Fix dir=auto traversal to not apply element-only rules to ancestors

This fixes Chromium code to match half of the spec update in
whatwg/html#10488 and
whatwg/html#10561 .  I previously thought the
code was fine, but I realize a small update is needed.  In particular,
the code could apply element-only rules for dir=auto to elements (in
particular, button-type inputs) that are auto-directionality
form-associated elements but were not in the list of exclusions.  This
also fixes the list of exclusions to exclude specifically textarea, so
that any actual text content of input elements (but not the value) is
traversed as required by the spec.

This also removes the no-longer needed is_deferred argument to
ResolveAutoDirectionality.

Bug: 576815, 352191350
Change-Id: I7c13b9661d23f8904727c8298a8dca6360d6d732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798880
Commit-Queue: David Baron <dbaron@chromium.org>
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1344402}

--

wpt-commits: 5fd1516871dc70888b9895f887109c39713db03e
wpt-pr: 47697
  • Loading branch information
dbaron authored and moz-wptsync-bot committed Aug 22, 2024
1 parent 2c15e79 commit b111bf6
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@
<div id=root>
<input value="اختبر">
<input type=text value="اختبر">
<input type=submit value="اختبر">
abc
</div>
</div>
Expand Down

0 comments on commit b111bf6

Please sign in to comment.