Bug 1823534 [wpt PR 39092] - [Local Network Access] Fix and assert un…

…defined server in WPTs, a=testonly

Automatic update from web-platform-tests
[Local Network Access] Fix and assert undefined server in WPTs

I found this bug when I was working on enabling the same-origin
exemption. Server defined outside of the target object is useless. The
URL will be resolved to the default HTTPS local.

Since we always explicitly define servers in LNA WPTs, asserting it so
we don't make the same mistake again.

Change-Id: I8f397a6ae4c442fb283ba7c2fca86c89f2aa322b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4355133
Reviewed-by: Titouan Rigoudy <titouan@chromium.org>
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1120002}

--

wpt-commits: 3a11c7f05d457bcf5514f35404fc13fa13b26a25
wpt-pr: 39092

testing/web-platform/tests/fetch/local-network-access/redirect.https.window.js

@@ -365,8 +365,8 @@ promise_test(t => fetchTest(t, {
     server: Server.HTTPS_LOCAL,
     treatAsPublic: true,
   },
-  server: Server.HTTPS_PRIVATE,
   target: {
+    server: Server.HTTPS_PRIVATE,
     behavior: {
       preflight: PreflightBehavior.noPnaHeader(token()),
       response: ResponseBehavior.allowCrossOrigin(),

testing/web-platform/tests/fetch/local-network-access/resources/support.sub.js

@@ -205,6 +205,7 @@ function sourceResolveOptions({ server, treatAsPublic }) {
 //   - `response`: The result of calling one of `ResponseBehavior`'s methods.
 //   - `redirect`: A URL to which the target should redirect GET requests.
 function preflightUrl({ server, behavior }) {
+  assert_not_equals(server, undefined, 'server');
   const options = {...server};
   if (behavior) {
     const { preflight, response, redirect } = behavior;