fix(deprecation): #2343 Check for deprecated APIs

[deeptibaghel]

fix(deprecation): #2343 Check for deprecated APIs

[deeptibaghel]

r? @vladikoff

[vladikoff]

@deeptibaghel we would need to add this here: mozilla/eslint-plugin-fxa#9 then plugin:fxa/server should have the new rules automatically and can be reused in other repositories.

[vladikoff]

same as comment above, let's make changes in eslint-plugin-fxa, land those as a pull request, then change this Git SHA in this pull request: https://github.com/mozilla/fxa-auth-server/blob/master/npm-shrinkwrap.json#L338

[vladikoff]

remove the ^ before the 2

[deeptibaghel]

do we need to change this as well , if yes what all we need to do ?

fxa-auth-server/npm-shrinkwrap.json

Line 81 in 86de08b

"punycode": {

"punycode": {
"version": "1.4.1",
"from": "https://registry.npmjs.org/punycode/-/punycode-1.4.1.tgz",
"resolved": "https://registry.npmjs.org/punycode/-/punycode-1.4.1.tgz"
}

[vladikoff]

would have to run npm run shrink for that to regenerate that file

[deeptibaghel]

@vladikoff when i run "npm run shrink", it creates a file which is having just around 5000 lines instead of current 10000 lines
when i run "npm shrink --dev" it creates a file which is having around 12000 lines.
So i think i am missing something.
I have just changed the SHA of eslint plugin in npm-shrinkwrap.json file as of now and the tests have passed.

[deeptibaghel]

@vladikoff , punycode.js is done.

[vladikoff]

@pdehaan @deeptibaghel does this work for you?

I Get:

 ᐅ grunt lint
Running "eslint:app" (eslint) task
Warning: Failed to load plugin node: Cannot find module 'eslint-plugin-node'
Referenced from: plugin:fxa/server
Referenced from: /Users/vladikoff/mozilla/fxa-local-dev/fxa-auth-server/.eslintrc Use --force to continue.

[vladikoff]

I wonder if this is because of npm2 vs npm3-5

[deeptibaghel]

I wonder if this is because of npm2 vs npm3-5

@vladikoff yeah i am using npm3

[vladikoff]

@deeptibaghel Thank you!!! 🎁