Bump react-aria from 3.34.1 to 3.34.3 #5038
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/react-aria-3.34.3
branch
2 times, most recently
from
b765af6 to
94a1813
Compare
|
Confirmed in the netlify preview that this update continues to create two random addresses when one is requested. Tracked in MPP-3893. |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/react-aria-3.34.3
branch
from
94a1813 to
f04a8b6
Compare
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/react-aria-3.34.3
branch
2 times, most recently
from
6a484bc to
d4a0795
Compare
Bumps [react-aria](https://github.com/adobe/react-spectrum) from 3.34.1 to 3.34.3. - [Release notes](https://github.com/adobe/react-spectrum/releases) - [Commits](https://github.com/adobe/react-spectrum/compare/react-aria@3.34.1...react-aria@3.34.3) --- updated-dependencies: - dependency-name: react-aria dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/react-aria-3.34.3
branch
from
d4a0795 to
92307a8
Compare
There was a problem hiding this comment.
Change looks good to me. I also noticed that it's no longer possible to reach the menu items via the down arrow (or other keys) on the keyboard, but that was already the case in main. That's an accessibility issue, but I'll leave the prioritisation to the team :)
| @@ -372,7 +372,6 @@ const AliasTypeMenuItem = (props: AliasTypeMenuItemProps) => { | |||
| { | |||
| key: props.item.key, | |||
| isDisabled: props.item.isDisabled, | |||
| onAction: props.onAction, | |||
There was a problem hiding this comment.
I think you should also be able to remove line 365 now.
There was a problem hiding this comment.
nice catch. Removed this (and the corresponding reference to this prop on line 346 too!)
Our AliasGenerationButton component passed onAction to both useMenu and useMenuItem hooks. react-aria has deprecated onAction handlers from the menu item level in favor of handling actions at the menu level. Previous versions of react-aria reconciled multiple handlers, but 3.43.3 does not. So our handler was being called twice, causing MPP-3893. (Note: the handler for custom masks was being called twice, but since it did not POST to create an address, it did not create 2 masks.)
groovecoder
force-pushed
the
dependabot/npm_and_yarn/react-aria-3.34.3
branch
from
c574271 to
00109ca
Compare
Bumps react-aria from 3.34.1 to 3.34.3.
Commits
87fc14aPublish5cd9581fix: truncate text in S2 ActionButton (#6919)d503a29update breadcrumbs to handle breadcrumb context overrides (#6920)72b8098Fix buttons in S2 dialogs stuck in hover state (#6916)d27e833types: fix S2 types/defaults (#6917)64e4a40Fix combobox focus from being lost when filtering large collections (#6913)1067affFix import path in icon and illustration .d.ts files (#6912)faf0e18August release (#6905)e17c7f4Release fixes (#6902)86eb91fCodemod: don't affect Items in unimplemented collection components (#6903)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)