Use pull request user login to detect "dependabot[bot]" #4997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to a recent article by synacktiv, the Dependabot credentials can be hijacked and used to create new jobs with: `github.actor == 'dependabot[bot]'` A way to check if dependabot is the real origin is to instead check: `github.event.pull_request.user.login == 'dependabot[bot]'` This check is repeated by the "dependabot/fetch-metadata@v2" code, so Relay has a partial mitigation. This change will more completely mitigate the issue.
This was for debugging the action while it was being developed.
|
Non-prod code, self-reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to a recent article by synacktiv, the Dependabot credentials can be hijacked and used to create new jobs with:
A way to check if dependabot is the real origin is to instead check:
This check is repeated by the "dependabot/fetch-metadata@v2" code, so Relay has a partial mitigation:
https://github.com/dependabot/fetch-metadata/blob/efb8718212b9b67ae628ffc209cccb93af694cd7/src/dependabot/verified_commits.ts#L26-L30
This PR will more completely mitigate the issue.