MPP-2822: add gtag to Layout and update gaEvent hook to ping both GA endpoints #4796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
changed the title
rafeerahman
approved these changes
Jun 21, 2024
| @@ -59,7 +60,6 @@ We collect data for the following extension events: | |||
|
|
|||
| - When panel navigation arrow icons are clicked | |||
|
|
|||
|
|
|||
| ### In-page events: | |||
|
|
|||
| - When the Relay icon is injected into an email input | |||
There was a problem hiding this comment.
Wondering if we need to make any updates in the add-on?
There was a problem hiding this comment.
Wow good catch. I'd like to get this part merged so we can test it ASAP, since the website more directly supports the Firefox integration, which is our current priority. I filed https://mozilla-hub.atlassian.net/browse/MPP-3831 as a follow-up to update the metrics_event endpoint for GA4.
rafeerahman
reviewed
Jun 21, 2024
| * | ||
| * @param props | ||
| */ | ||
| export const GoogleAnalyticsWorkaround = ( |
There was a problem hiding this comment.
curious, whats the purpose of this?
There was a problem hiding this comment.
Copied from Monitor code, TBH. Sounds like it's the same as GoogleAnalytics but it accepts a nonce parameter. I'll dig in to see if we can remove that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GA4
Screenshot
How to test
frontend/runnpm run devfrontend/runnpm run buildpython manage.py collectstaticpython manage.py runserverChecklist (Definition of Done)
Customer Experience team has seen or waived a demo of functionality.All UI revisions follow the coding standards, and use Protocol tokens where applicable (see/frontend/src/styles/tokens.scss).l10n changes have been submitted to the l10n repository, if any.