Skip to content

Commit

Permalink
Remove google-cloud-sqlcommenter
Browse files Browse the repository at this point in the history
This package does not work with Python 3.12. The code was donated to
OpenTelemetry, but they have not integrated it into their codebase.
  • Loading branch information
jwhitlock committed Nov 12, 2024
1 parent cb75394 commit 3365c96
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
10 changes: 0 additions & 10 deletions privaterelay/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,6 @@
except ImportError:
HAS_SILK = False

try:
import google.cloud.sqlcommenter # noqa: F401

HAS_SQLCOMMENTER = True
except ImportError:
HAS_SQLCOMMENTER = False

try:
from privaterelay.glean.server_events import GLEAN_EVENT_MOZLOG_TYPE
except ImportError:
Expand Down Expand Up @@ -405,9 +398,6 @@
"privaterelay.middleware.StoreFirstVisit",
]

if HAS_SQLCOMMENTER:
MIDDLEWARE.append("google.cloud.sqlcommenter.django.middleware.SqlCommenter")

ROOT_URLCONF = "privaterelay.urls"

TEMPLATES = [
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ drf-spectacular==0.27.2
drf-spectacular-sidecar==2024.11.1
glean_parser==15.2.1
google-cloud-profiler==4.1.0; python_version < '3.13'
google-cloud-sqlcommenter==2.0.0; python_version < '3.12'
gunicorn==23.0.0
jwcrypto==1.5.6
markus[datadog]==5.1.0
Expand Down

0 comments on commit 3365c96

Please sign in to comment.