-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build breaks with v0.24.6 #841
Comments
Unfortunately the latest cbindgen release added private field to a public struct, breaking our build. Work around this until mozilla/cbindgen#841 is fixed.
Same issue here trying to build https://github.com/fzyzcjy/flutter_rust_bridge . https://github.com/rust-lang/rfcs/blob/master/text/1105-api-evolution.md
|
@emilio This seems quite urgent. |
Yep, thanks. Yanked 0.24.6. Sorry for not catching that during review. Will publish 0.25 later this week. Let me know if a 0.24.7 with that change reverted would make someone's life easier. |
Thanks for the quick reaction and fix! |
This will fail creating a new github release, if the semver action fails. This would have caught mozilla#841.
This will fail creating a new github release, if the semver action fails. This would have caught mozilla#841.
This will fail creating a new github release, if the semver action fails. This would have caught #841.
I'm confused - it looks like this is still broken (or maybe broken again)? I guess based on the CHANGELOG it was decided to keep this breaking change?
|
PR #820 changed the config struct in a way that breaks existing code:
Our code initialises
Config
not via::default()
but like this:and that causes
I can work around this of course by using
Config::default()
, but unfortunately the crate release with this change breaks our existing crate on crates.io that relies on this :-(The text was updated successfully, but these errors were encountered: