[WIP] Prettier plugin for eslint #703
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,73 +1,77 @@ | ||
| { | ||
| "name": "bramble", | ||
|
|
||
| "version": "1.9.0-0", | ||
| "apiVersion": "1.9.0", | ||
| "homepage": "https://mozillathimblelivepreview.net/bramble/staging/dist/hosted.html", | ||
| "issues": { | ||
| "url": "http://github.com/mozilla/brackets/issues" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/mozilla/brackets.git", | ||
| "branch": "", | ||
| "SHA": "" | ||
| }, | ||
| "dependencies": { | ||
| "anymatch": "1.3.0", | ||
| "aws-sdk": "^2.19.0", | ||
| "chokidar": "1.6.0", | ||
| "glob": "7.0.6", | ||
| "grunt": "0.4.5", | ||
| "grunt-cleanempty": "1.0.3", | ||
| "grunt-cli": "0.1.9", | ||
| "grunt-contrib-clean": "0.4.1", | ||
| "grunt-contrib-compress": "^1.4.1", | ||
| "grunt-contrib-concat": "0.3.0", | ||
| "grunt-contrib-copy": "0.4.1", | ||
| "grunt-contrib-cssmin": "0.6.0", | ||
| "grunt-contrib-htmlmin": "0.1.3", | ||
| "grunt-contrib-jasmine": "0.4.2", | ||
| "grunt-contrib-less": "1.4.0", | ||
| "grunt-contrib-requirejs": "0.4.1", | ||
| "grunt-contrib-uglify": "^2.3.0", | ||
| "grunt-contrib-watch": "0.4.3", | ||
| "grunt-eslint": "19.0.0", | ||
| "grunt-exec": "^1.0.1", | ||
| "grunt-jasmine-node": "0.1.0", | ||
| "grunt-lib-phantomjs": "0.3.0", | ||
| "grunt-targethtml": "0.2.6", | ||
| "grunt-template-jasmine-requirejs": "0.1.0", | ||
| "grunt-usemin": "0.1.11", | ||
| "jasmine-node": "1.11.0", | ||
| "less-plugin-autoprefix": "^1.5.1", | ||
| "load-grunt-tasks": "3.5.0", | ||
| "lodash": "4.15.0", | ||
| "phantomjs": "1.9.18", | ||
| "q": "1.4.1", | ||
| "semver": "^4.1.0", | ||
| "xmldoc": "^0.1.2" | ||
| }, | ||
| "devDependencies": { | ||
| "bluebird": "^3.4.7", | ||
| "eslint-config-prettier": "^1.6.0", | ||
| "eslint-plugin-prettier": "^2.0.1", | ||
| "grunt-githooks": "^0.6.0", | ||
| "gunzip-maybe": "^1.3.1", | ||
| "http-server": "^0.9.0", | ||
| "mkdirp": "0.5.1", | ||
| "nunjucks": "^2.4.3", | ||
| "prettier": "^0.22.0", | ||
| "properties-parser": "0.3.1", | ||
| "request": "^2.69.0", | ||
| "requirejs": "^2.3.3", | ||
| "sw-precache": "^5.0.0", | ||
| "tar-fs": "^1.15.1" | ||
| }, | ||
| "scripts": { | ||
| "localize": "node scripts/properties2js", | ||
| "postinstall": "grunt install", | ||
| "build": "grunt build-browser", | ||
| "preproduction": "grunt build-browser-compressed && grunt unlocalize", | ||
| "production": "npm start", | ||
| "unlocalize": "grunt unlocalize", | ||
| "test": "grunt test && grunt build-browser-compressed", | ||
| "start": "http-server -p 8000 --cors" | ||
| }, | ||
| "license": "MIT" | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems wrong to me. We'd want this to run automatically, not just when you manually run
build. That is, when Icommit, or maybe even when I just stage changes, it should run. There should be no manual intervention required, or people will forget/not-know to do it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@humphd This is required to create githook scripts. The formatting does run automatically on before every commit. My comment above
Only refers to the first run of the build. Eslint does not have auto-fixing set, so styling will fail the build and you will never create githook scripts. So instead you need to format code manually once, and then it will run properly on every commit. After formatted code is committed to the master, there will be no need for manual intervention.