Cut v0.16.0 release. #627
Cut v0.16.0 release. #627
Conversation
|
/cc @joeyg for context; hopefully this will include everything you need to consume build artifacts for lockbox? |
|
@eoger just to check, are the circleci failures here expected due to the known issues with build time/resources, or unexpected? |
Looks like it's OOM :/ |
For places we don't maintain the wrapper (there is no wrapper, although I think they have a mock implementing PlacesAPI). File an issue for them to bump it, example: mozilla-mobile/android-components#1930, CC @grigoryk |
| ## Places | ||
|
|
||
| ### Breaking Changes | ||
|
|
||
| - Several new methods on PlacesConnection (Breaking changes for classes implementing PlacesAPI): |
There was a problem hiding this comment.
Are these "breaking changes" in the "your existing code in another repo will stop working", or is this just flagging that work as to be done to implement the new methods? It's not clear from the details below what breakage will be caused by the new methods.
There was a problem hiding this comment.
It will be a compilation failure. You're not allowed to implement only some of the methods in an interface, and so us adding new methods means that anybody using this interface must update or their code will break. I wouldn't refer to the other as a breaking change.
|
Yes, any code that contains a class that implements PlacesAPI will break,
as it will no longer implement all the required methods.
…On Wed, Feb 6, 2019 at 1:48 PM Ryan Kelly ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CHANGELOG.md
<#627 (comment)>
:
>
### What's New
+- iOS builds now target v11.0. ([#614](#614))
+- Preparatory infrastructure for megazording iOS builds has landed.([#625](#625))
+
+## Places
+
+### Breaking Changes
+
- Several new methods on PlacesConnection (Breaking changes for classes implementing PlacesAPI):
Are these "breaking changes" in the "your existing code in another repo
will stop working", or is this just flagging that work as to be done to
implement the new methods? It's not clear from the details below what
breakage will be caused by the new methods.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#627 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0h-bClpq-tVYKKCCiGcyiCY5rsEJ-2ks5vK02bgaJpZM4amKH_>
.
|
@thomcc and/or @mhammond, flagging you for review because I had some questions about the places change. Is it correct to flag as "breaking change" and should we file any follow-up bugs about making the changes over in a-c repo?