Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode Megazord project #624

Closed
wants to merge 3 commits into from

Conversation

garvankeeley
Copy link
Contributor

Prototype of what this might look like, the base branch is swift-rc-log.

  • String+Free.swift exists twice, this needed renaming
  • Errors.swift same as above

Prototype of what this might look like
@garvankeeley garvankeeley added the WIP Work in progress label Feb 5, 2019
@garvankeeley
Copy link
Contributor Author

The xcode project itself contains all the files from Logins and FxAClient, nothing too fancy happening here:
screenshot 2019-02-05 16 22 17

@thomcc
Copy link
Contributor

thomcc commented Feb 5, 2019

I'm a little surprised you need the separate libsqlcipher.a, but this looks really good!

@garvankeeley
Copy link
Contributor Author

I don't know if libsqlcipher.a is needed, I was trying to preserve the bits from the Logins and FxAClient when I mashed them together. This isn't compiling, I am getting a ton of Rust symbol errors, as if no symbols from the megazord lib are being resolved.

@thomcc
Copy link
Contributor

thomcc commented Feb 5, 2019

That's not good, I'll look into it after meetings. I wonder if the things we're doing to work around rust-lang/rust#50007 don't work on iOS (when I checked before they seemed to, but hard to say)

@garvankeeley
Copy link
Contributor Author

the "umbrella header" for cross lang linking isn't correctly specified, fixing it now

@garvankeeley
Copy link
Contributor Author

garvankeeley commented Feb 5, 2019

All that is left is a minor issue with the queue being defined in both projects.
I'll look at containment of that var now.

image

This is the KISS way of having the serial queue defined for each project.
@garvankeeley
Copy link
Contributor Author

In order to split up this WIP commit to the parts that are immediately landable, I did this PR
#625

@garvankeeley garvankeeley deleted the garvan/ios-megazord-xcodeproj branch February 19, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants