Skip to content

Conversation

diox
Copy link
Member

@diox diox commented Oct 2, 2025

Fixes: mozilla/addons#15874

Context

A lot of this code has been dead for years:

  • We used to have webapps, some of them paid, through Firefox OS Marketplace. That is long gone, all related strings and code is obsolete
  • We used to have global stats displayed using that code, also long gone
  • We used to have download sources constants that we used and developers could use to track downloads with the src parameter, now it's using utm parameters that are completely different

Description

This removes the dead code and strings associated with those obsolete features. In total that's 114 strings that were translated but completely useless.

Testing

  • Follow the (updated) Test Statistics Dashboard runbook to get stats working (including downloads)
  • Browse through each item in the statistics dashboard and ensure everything loads correctly
  • Repeat in a language with 100% strings translated like French and ensure everything is translated correctly

@diox diox changed the title Remove dead code and strings from statistics Remove dead JavaScript code and strings from statistics Oct 2, 2025
@diox diox marked this pull request as ready for review October 3, 2025 14:02
@diox diox requested review from willdurand and eviljeff and removed request for willdurand October 3, 2025 14:02
Copy link
Member

@eviljeff eviljeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(unconnected, but we should do a better job of documenting how to enable localization - make compile_locales, etc - I had a head scratching moment when nothing was in French.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove dead code/strings in statistics
2 participants