allow approval notes to be set by developers via the addon submission api #19579
Conversation
eviljeff
requested review from
a team,
bobsilverberg and
diox
and removed request for
a team and
bobsilverberg
| approval_notes = models.TextField( | ||
| db_column='approvalnotes', default='', null=True, blank=True | ||
| ) | ||
| approval_notes = models.TextField(db_column='approvalnotes', default='', blank=True) |
There was a problem hiding this comment.
The only problem here is this change would mean any versions created during the push window would fail (as they'd still be created with approval_notes=null). If we think that's a big enough problem we could delay the migration - the change in from_upload should be enough to fix new versions.
There was a problem hiding this comment.
I think it's better to err of the side of caution here - we don't know what might happen that could delay the deploy part of the push. So let's be conservative and do that migration later.
| approval_notes = models.TextField( | ||
| db_column='approvalnotes', default='', null=True, blank=True | ||
| ) | ||
| approval_notes = models.TextField(db_column='approvalnotes', default='', blank=True) |
There was a problem hiding this comment.
I think it's better to err of the side of caution here - we don't know what might happen that could delay the deploy part of the push. So let's be conservative and do that migration later.
fixes mozilla/addons#8835