Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor addon related serializers & fields; add source field #18729

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

eviljeff
Copy link
Member

@eviljeff eviljeff requested review from a team and bobsilverberg and removed request for a team January 31, 2022 16:33
@eviljeff eviljeff force-pushed the 9913-addons-api-source-submission branch from 66cf1d9 to e07345c Compare January 31, 2022 16:33
@eviljeff
Copy link
Member Author

(A lot of the change in this patch is just moving all the Field classes into fields.py - serializers.py was already very long and before I added yet another chunk of code to it I split it up)

Copy link
Contributor

@bobsilverberg bobsilverberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just have a few questions.

r+wc

docs/topics/api/overview.rst Outdated Show resolved Hide resolved
src/olympia/addons/serializers.py Outdated Show resolved Hide resolved
src/olympia/addons/tests/test_views.py Outdated Show resolved Hide resolved
@eviljeff eviljeff merged commit b827c6c into mozilla:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow upload of source code (and release/reviewer notes) using the API
3 participants