Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid comparing bytes and str in Python 3 #10672

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Avoid comparing bytes and str in Python 3 #10672

merged 2 commits into from
Feb 13, 2019

Conversation

diox
Copy link
Member

@diox diox commented Feb 12, 2019

@diox diox force-pushed the py3-fix-bytes-str-mix branch from e0da291 to 5848d7c Compare February 12, 2019 18:37
EnTeQuAk
EnTeQuAk approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@EnTeQuAk EnTeQuAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. r+ if travis generally agrees (I know that we don't throw anything just yet)

@diox diox merged commit f6a066c into mozilla:master Feb 13, 2019
MelissaAutumn pushed a commit to thunderbird/addons-server that referenced this pull request May 21, 2024
@diox @MelissaAutumn
Avoid comparing bytes and str in Python 3 (mozilla#10672)
e9db9dd 
(cherry picked from commit f6a066c)
MelissaAutumn pushed a commit to thunderbird/addons-server that referenced this pull request Jun 10, 2024
@diox @MelissaAutumn
Avoid comparing bytes and str in Python 3 (mozilla#10672)
de49306 
(cherry picked from commit f6a066c)
MelissaAutumn pushed a commit to thunderbird/addons-server that referenced this pull request Aug 25, 2024
@diox @MelissaAutumn
Avoid comparing bytes and str in Python 3 (mozilla#10672)
942e696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnTeQuAk EnTeQuAk EnTeQuAk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken comparisons/formatting between bytes and str in python 3
2 participants
@diox @EnTeQuAk