Avoid clashes on .git folders during git-extraction. #10632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files are now extracted into a `extracted/` folder to have a 100% clean surface and avoid any clashes. In addition to that we are now appending a random postfix to .git folders because for security reasons git doesn't allow .git folders in any sub directory (e.g for git commit-hooks etc) Fixes #10562
eviljeff
approved these changes
Feb 8, 2019
MelissaAutumn
pushed a commit
to thunderbird/addons-server
that referenced
this pull request
Aug 25, 2024
Files are now extracted into an `extracted/` folder to have a 100% clean surface and avoid any clashes. In addition to that, we are now appending a random postfix to .git folders because for security reasons git doesn't allow .git folders in any subdirectory (e.g for git commit-hooks etc) Aside from that, this renames the `package` folder to `addon` for a better understanding of its usage. Fixes #10562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files are now extracted into an
extracted/folder to have a 100% cleansurface and avoid any clashes.
In addition to that, we are now appending a random postfix to .git
folders because for security reasons git doesn't allow .git folders in
any subdirectory (e.g for git commit-hooks etc)
Aside from that, this renames the
packagefolder toaddonfor a better understanding of its usage.Fixes mozilla/addons#6363