-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colons don't work #81
Comments
What browser / OS? Renders ok here on Linux Firefox nightly. |
Looks like it's only on Chrome (42.0.2311.90) in OSX (tried in 10.10.3 and 10.9) |
This looks like it's probably a Chrome bug. The same problem occurs with several other characters that are composed (in the TrueType version) of two or more copies of the same "component" glyph: try " ‖ „ … |
Ahh.. yeah those don't work either. Can this be fixed? 😕 |
Actually, I think this is a font bug, not a Chrome bug. Looking at the colon glyph in a TTX dump, for example:
The bounding box in the glyph data here does not account for the second (shifted) component glyph. I guess this is a bug in Glyphs.app, assuming that's what is being used to create the TTF files. |
@carrois, can you look into this, and report to Georg if it's confirmed as a Glyphs bug? |
We talked to Georg – this seems to be a known issue for some browsers under some circumstances. But he finally found a way to solve it within the export process. @ Patryk: are there any further issues for this update except from the Gaelic ampersand?! |
I don't think this is fixed yet in 4.101: dumping the 'glyf' table shows the "colon" glyph unchanged as
which still has an incorrect bounding box. |
Think we have address that to Georg once more. |
I just tried to fix that by decomposing /colon. Please download the files once more. |
I just re-downloaded, and checked a few of the glyphs. In this version, it appears that ALL composites have been decomposed in the TTF version (whether or not they were affected by the bug). So this version should work around the rendering problem -- the glyphs now have correct bounding boxes, AFAICS -- but it's a workaround rather than a proper fix, and it means the resulting TTF files are substantially larger than they should be. (E.g. FiraSans-Regular.ttf has grown from 405868 bytes to 592288 bytes, an increase of 45% ... ouch!) Please press Georg to actually fix the underlying bug, rather than just decomposing everything to avoid it, so that TTF fonts with components can be correctly generated. |
Just updated to 4.102 and Mono 3.202 exported by Glyphs build 744. |
Yes, this appears to fix the bounding box issue, and these glyphs no longer get clipped in some applications. Thanks! I notice that the "colon" glyph in Fira Sans is still the decomposed version; now that the composite export bounding-box bug is fixed, you can presumably revert this and keep the composite glyph here. |
Looks OK now in 4.103. |
Just noticed this while using the font but colons are rendered as periods. Seems to be the case on the type tester at http://www.carrois.com/en/fira-4-1/ as well.
The text was updated successfully, but these errors were encountered: