-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical metrics should be equal for consistent spacing across platforms #43
Comments
codeman38
changed the title
usWinAscent and usWinDescent need to be changed for Windows GDI renderer
Vertical metrics should be equal for consistent spacing across platforms
Jun 6, 2014
fixed within next version coming this week |
patrykdesign
pushed a commit
that referenced
this issue
Jun 27, 2014
version/build 3.109 _ #43 * impossible to get equal values for all OS issues with common methods. = catch: > set typoLineGap to 400 (was 200) > set winDescender to -350 (was -500) ! known bug: cuts of lowest glyphs (-353 Ultra) ? Arabic (should not become lower) ? Vietnamese (should not become higher) _ fixed zero width glyphs with no zero value _ fixed PS hinting issues coming up changing grid in the very thin weights
patrykdesign
pushed a commit
that referenced
this issue
Jun 27, 2014
version/build 3.109 _ #43 * impossible to get equal values for all OS issues with common methods. = catch: > set typoLineGap to 400 (was 200) > set winDescender to -350 (was -500) ! known bug: cuts of lowest glyphs (-353 Ultra) ? Arabic (should not become lower) ? Vietnamese (should not become higher) _ fixed zero width glyphs with no zero value _ fixed PS hinting issues coming up changing grid in the very thin weights
@codeman38 should be fixed in v.3.110, can you verify? |
Yep, looks good to me in 3.110 - line height is consistently 1.4 ems. Closing this bug. |
zwaldowski
pushed a commit
to zwaldowski/Fira
that referenced
this issue
Oct 4, 2014
version/build 3.109 _ mozilla#43 * impossible to get equal values for all OS issues with common methods. = catch: > set typoLineGap to 400 (was 200) > set winDescender to -350 (was -500) ! known bug: cuts of lowest glyphs (-353 Ultra) ? Arabic (should not become lower) ? Vietnamese (should not become higher) _ fixed zero width glyphs with no zero value _ fixed PS hinting issues coming up changing grid in the very thin weights
zwaldowski
pushed a commit
to zwaldowski/Fira
that referenced
this issue
Oct 4, 2014
version/build 3.109 _ mozilla#43 * impossible to get equal values for all OS issues with common methods. = catch: > set typoLineGap to 400 (was 200) > set winDescender to -350 (was -500) ! known bug: cuts of lowest glyphs (-353 Ultra) ? Arabic (should not become lower) ? Vietnamese (should not become higher) _ fixed zero width glyphs with no zero value _ fixed PS hinting issues coming up changing grid in the very thin weights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In version 3.108 of Fira, the
sTypo
metrics (sTypoAscender
,sTypoDescender
,sTypoLineGap
) have been set to 785, 215, and 200, respectively, for a total line height of 1200 (i.e., 1.2 ems). This is good-- this does indeed match what was present in version 2 of the fonts.However, at least two major OSes' font renderers do not use the
sTypo
metrics at all-- in particular, Windows GDI uses theusWin
metrics consistently, while Mac OS X uses thehhea
metrics consistently, regardless of the value of theUSE_TYPO_METRICS
flag. (See http://typophile.com/node/13081 for further discussion of this.) DirectWrite on Windows does obey thesTypo
metrics--but unfortunately, there are still some Windows machines (such as my work laptop) where DirectWrite's rendering is very buggy, forcing the use of GDI.The total line height as measured by both of these sets of metrics should be equal to the total line height from the
sTypo
metrics. Unfortunately, in the case of Fira, they're not. With an ascender of 1050 and a descender of 500, the total line height as measured by these metrics is 1550 (1.55 ems). As a result, line spacing is not identical across OSes.The text was updated successfully, but these errors were encountered: