Migrate service-status from argparse to click #48
+51
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
force-pushed
the
relud-click-service-status
branch
from
a339564
to
cb18cd4
Compare
relud
force-pushed
the
relud-click-service-status
branch
from
cb18cd4
to
a9fb37e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #39
manually tested by running:
make shell service-status # expect error message about no hosts service-status --host=stage=https://crash-stats.allizom.orgI didn't add CI tests because CI shouldn't depend on github being up, but also mocking out github and an http server seemed excessive. If adding a test like that is desirable lmk.