Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peg to some nightly rust for Docker builds #25

Closed
pjenvey opened this issue Apr 2, 2018 · 1 comment
Closed

Peg to some nightly rust for Docker builds #25

pjenvey opened this issue Apr 2, 2018 · 1 comment
Assignees
@pjenvey
Labels
enhancement New feature or request p1

Comments

@pjenvey
Copy link
Member

pjenvey commented Apr 2, 2018

Rocket requires nightly rust, we're currently YOLO building the Docker with the latest nightly rust. At the very least we should peg to some specific nightly for at least some stability/reproducability here.
@pjenvey pjenvey added enhancement New feature or request p3 labels Apr 2, 2018
pjenvey added a commit that referenced this issue Apr 5, 2018
@pjenvey
feat: peg Docker build to rust nightly-2018-04-04
f17d492 
Closes #25
@pjenvey pjenvey added p1 and removed p3 labels Apr 5, 2018
@pjenvey
Copy link
Member Author

pjenvey commented Apr 5, 2018

making a p1 given rocket's new release and a recent nightly both broke builds for their own different reasons this week

@pjenvey pjenvey mentioned this issue Apr 5, 2018
Merged
@pjenvey pjenvey self-assigned this Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
enhancement New feature or request p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjenvey @jrconlin