This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
Rename Contile integration tests to contract tests #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinaa
force-pushed
the
rename-integration-to-contract-tests
branch
from
8f56d0f to
6888426
Compare
pjenvey
previously approved these changes
Jun 2, 2022
|
Merging is currently blocked because we require all commits on Contile to be signed. There's a GitHub docs page on GPG signing at https://docs.github.com/articles/about-gpg/. |
Trinaa
force-pushed
the
rename-integration-to-contract-tests
branch
from
6888426 to
c812fc4
Compare
@hackebrot I seemed to have fallen into a pitfall, where my signatures end up lost. I'm not sure if forcing signature verification is correct/optimal/allowed |
|
Hi @Trinaa! 👋🏻 My bad. I wasn't aware of this when I suggested you rebase using the GitHub web UI. I recommend you rebase your local commits to the latest |
Trinaa
force-pushed
the
rename-integration-to-contract-tests
branch
from
c812fc4 to
1679aa5
Compare
hackebrot
approved these changes
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request renames the integration-tests directory to contract-tests and updates references in the documentation and CI configuration.
This change clarifies the test suite purpose and distinguishes the suite from the more internal Rust based integration tests.
Issue(s)
CONSVC-1784