Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

feat: add a /__test_loc__ dockerflow endpoint #282

Merged
merged 6 commits into from
Sep 22, 2021
Merged

Conversation

jrconlin
Copy link
Member

Closes #281

Description

Adds a /__test_loc__ that returns minimal location resolution information.

Testing

https:///test_loc
This will use the X-FORWARDED-FOR IP address value

Issue(s)

Closes #281

@jrconlin jrconlin requested a review from a team September 16, 2021 23:37
Copy link
Member

@hackebrot hackebrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jrconlin! 👋🏻

Do you mind adding a unit test to verify that that the new API endpoint is defined and returns 200 OK with a non-empty response body?

@jrconlin jrconlin requested a review from hackebrot September 22, 2021 18:33
src/adm/tiles.rs Outdated
@@ -123,6 +123,7 @@ pub fn filtered_dma(exclude: &Option<Vec<u16>>, dma: &u16) -> String {

/// Main handler for the User Agent HTTP request
///
/// This calls out to the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray or unfinished comment, kill?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, broken comment from a failed merge.
thanks!

@pjenvey pjenvey merged commit d28584d into main Sep 22, 2021
@pjenvey pjenvey deleted the feat/281-test_loc branch September 22, 2021 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a dockerflow endpoint to test location responses
3 participants