This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Reduce concurrent adM requests #248
Comments
pjenvey
added a commit
that referenced
this issue
Aug 9, 2021
by storing state about active adM requests in the cache when a request's in the process of populating a cache entry for the first time, subsequent requests will 503 until it's completed when a request's in the process of refreshing an existing cache entry, subsequent requests will return the stale entry until it's completed and cache empty for BadAdmResponse errors (which haven't happened yet) Closes #248
pjenvey
added a commit
that referenced
this issue
Aug 9, 2021
by storing state about active adM requests in the cache when a request's in the process of populating a cache entry for the first time, subsequent requests will 503 until it's completed when a request's in the process of refreshing an existing cache entry, subsequent requests will return the stale entry until it's completed and cache empty for BadAdmResponse errors (which haven't happened yet) Closes #248
jrconlin
added a commit
that referenced
this issue
Aug 9, 2021
by storing state about active adM requests in the cache when a request's in the process of populating a cache entry for the first time, subsequent requests will 503 until it's completed when a request's in the process of refreshing an existing cache entry, subsequent requests will return the stale entry until it's completed and cache empty for BadAdmResponse errors (which haven't happened yet) Closes #248 Co-authored-by: JR Conlin <jconlin+git@mozilla.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When first populating or refreshing contile's cache with content from adM, multiple requests for the same content can be triggered simultaneously. Many of these request are redundant, which:
With Contile now handling image hosting its processing task is potentially lengthier, which could result in even larger number of redundant concurrent requests triggered (since the cache doesn't fill as quickly).
To improve this: when an adM request is triggered Contile could write this event to its cache, letting subsequent requests act more intelligently. Instead of spawning more requests they could instead: wait for that adM request to finish (by simply 503ing the client or actually waiting over an spmc channel for its completion) or by simply returning stale content until the request finishes.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: