Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Return 204 No Content for cache hits #191

Closed
pjenvey opened this issue Jun 23, 2021 · 0 comments · Fixed by #199
Closed

Return 204 No Content for cache hits #191

pjenvey opened this issue Jun 23, 2021 · 0 comments · Fixed by #199
Assignees
@pjenvey
Labels
bug Something isn't working

Comments

@pjenvey
Copy link
Member

pjenvey commented Jun 23, 2021 •
edited by data-sync-user
Loading

#152 began caching empty result sets but upon a cache hit we always return 200 OK.

Cache hits should check for empty tiles and return 204s in the case of empty tiles.

┆Issue is synchronized with this Jira Task
@pjenvey pjenvey added the bug Something isn't working label Jun 23, 2021
@pjenvey pjenvey self-assigned this Jun 23, 2021
pjenvey added a commit that referenced this issue Jun 24, 2021
@pjenvey
fix: return 204 no contents for cache hits
d2fb577 
Closes #191
@pjenvey pjenvey mentioned this issue Jun 24, 2021
Merged
pjenvey added a commit that referenced this issue Jun 24, 2021
@pjenvey
fix: return 204 no contents for cache hits
c65a5dd 
Closes #191
pjenvey added a commit that referenced this issue Jun 24, 2021
@pjenvey
fix: return 204 no contents for cache hits
5d81a82 
Closes #191
pjenvey added a commit that referenced this issue Jun 25, 2021
@pjenvey
fix: return 204 no contents for cache hits
5c31819 
Closes #191
pjenvey added a commit that referenced this issue Jun 25, 2021
@pjenvey
fix: return 204 no contents for cache hits (#199)
b8afa23 
Closes #191
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: return 204 no contents for cache hits mozilla-services/contile
1 participant
@pjenvey