Add FXIOS-6706 [v116] Screen Time implementation

[FilippoZazzeroni]

Jira ticket
Github issue

Description

Added implementation of Screen Time functionalities. To test this implementation use a real device, because on simulator screen time doesn't work. In order to test it, go to Settings > Screen Time > Content & Privacy Restrictions > Content Restrictions > Web Content and select Limit Adult Websites or Allowed Websites then navigate to a restricted page and you should see that the navigation is disabled.

Pull requests checks where applicable

• Fill in the three TODOs above (tickets number and description of your work)
• The PR name follows our naming guidelines
• Accessibility implemented and tested (minimum Dynamic Text and VoiceOver)
• Unit tests written and passing
• Documentation / comments for complex code and public methods

[mobiletest-ci-bot]

	Messages
📖	Project coverage: 35.97%
📖	Edited 2 files
📖	Created 0 files

Client.app: Coverage: 34.27

File	Coverage
WebviewViewController.swift	54.93%	✅
AppSettingsTableViewController.swift	12.44%	⚠️

Generated by 🚫 Danger Swift against bc6019e

[thatswinnie]

I think we should use constraints here as well instead of setting a frame to avoid problems with rotation or other screen size changes.

[FilippoZazzeroni]

ok perfect i'm changing it

[thatswinnie]

Thank you so much @FilippoZazzeroni for implementing screen time! This is great!

[FilippoZazzeroni]

You're welcome @thatswinnie 🚀. Thank you a lot for your reviews.

[domcorvasce]

@FilippoZazzeroni @thatswinnie just a heads up: the current solution is also tracking page usage in incognito mode.
STWebpageController has no concept of "incognito mode" so it's up to the browser vendor to add checks (e.g. by setting suppressUsageRecording to true).
Neither Safari nor Chrome count incognito tabs towards screen time. Shouldn't Firefox follow the same behaviour?

[FilippoZazzeroni]

@domcorvasce thank you. i see safari when you enable content restrictions it disables the incognito mode, however if you can suppress the recording when you are in incognito mode, we should just set that boolean to true if we are in private mode. what do you think @thatswinnie ?

[domcorvasce]

I see safari when you enable content restrictions it disables the incognito mode

@FilippoZazzeroni that's a good point. We could use WebContentSettings.blockedByFilter to block incognito mode if content restrictions are enabled but I wouldn’t do it just like Chrome doesn’t.

One last note. I think there is some misunderstanding about this PR.
The disabled navigation is built in WebKit (at least in iOS 16). Try running the current Firefox iOS build from the App Store—which doesn't include this feature. It will still disable navigation for blocked websites.

This PR is adding support for Screen Time limits on web content, and the ability of Screen Time to show a time breakdown per website.

Disabling incognito mode should be discussed as part of a separate Family Controls integration.

[FilippoZazzeroni]

@domcorvasce ok. I think just turn true the suppressUsageRecording is simpler than check manged settings, when we are in private mode. Because i think you need to request authorization in order to access managed settings.

[FilippoZazzeroni]

I see safari when you enable content restrictions it disables the incognito mode

@FilippoZazzeroni that's a good point. We could use WebContentSettings.blockedByFilter to block incognito mode if content restrictions are enabled but I wouldn’t do it just like Chrome doesn’t.

One last note. I think there is some misunderstanding about this PR. The disabled navigation is built in WebKit (at least in iOS 16). Try running the current Firefox iOS build from the App Store—which doesn't include this feature. It will still disable navigation for blocked websites.

This PR is adding support for Screen Time limits on web content, and the ability of Screen Time to show a time breakdown per website.

Disabling incognito mode should be discussed as part of a separate Family Controls integration.

Ok maybe a solution could be to add the screen time implementation to entire browser view controller view, in order to limit the screen time to entire app, and suppress the recording inside web view controller when incognito mode is enabled. i don't think is needed to disable the incognito mode, since parental control can work on that too.