Bug 1207044 - Refactor L10n/Intl in Clock to prepare for NGA #31961
Conversation
| nSpinnerHours[two] = {{n}} hours | ||
| nSpinnerHours[few] = {{n}} hours | ||
| nSpinnerHours[many] = {{n}} hours | ||
| nSpinnerHours[other] = {{n}} hours |
There was a problem hiding this comment.
those were not used
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
7a5463b to
8d25446
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
09f7a44 to
6a6c422
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
6a6c422 to
f13abd9
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
f13abd9 to
7aa4bee
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
7aa4bee to
8e16fc1
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
8e16fc1 to
3836442
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
3836442 to
f295031
Compare
| } | ||
|
|
||
| this.spinners[picker] = new Spinner({ | ||
| element: this.nodes[picker], | ||
| values: values, | ||
| textValues: textValues.length ? textValues : values | ||
| isPadded: isPadded, | ||
| l10nId: setup.pickers[picker].l10nId | ||
| }); |
There was a problem hiding this comment.
I'm considering making the picker reverse the order of spinners for RTL. I'll wait for @anefzaoui opinion
There was a problem hiding this comment.
At this point we're in a good shape to follow the spec as we finally have a near-final, polished one.
[in RTL] Continuous/Spinner Icon and animation (should point and move counter clockwise)
From Page 4
https://bug1179459.bmoattachments.org/attachment.cgi?id=8663887
So indeed we should mirror those :)
There was a problem hiding this comment.
Sweet. Added. I was able to accomplish that exclusively in CSS!
There was a problem hiding this comment.
After IRC chat with Zibi, it turns out I was mistaking the clock time spinner with the round arrow icon that happens to be also called spinner.
For the clock time spinner/picker, it should NOT be RTL'ed.
if there's a suffix it should look like "p hh:mm" and if there isn't it should be "hh:mm"
Sorry for the confusion!
There was a problem hiding this comment.
Sweet! Reverted! I'm expert in time pickers now! AMA!
|
I see one more bug - sometimes after switching locales back and forth I move time picker to 0:0 and the "create" button is not getting disabled. Will fix it tomorrow |
|
|
||
| alarmMinutes={[ plural(minutes) ]} | ||
| alarmMinutes[zero] = less than a minute | ||
| alarmMinutes[one] = one minute |
There was a problem hiding this comment.
OCD moment: fix weird indentation in zero/one cases (also for nSpinnerMinutes.ariaValuetext)?
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
6e16510 to
ac0c7be
Compare
|
|
||
| # Character used in timePicker to separate hours from minutes | ||
| hourMinutesSeparator=: | ||
|
|
||
| # Separator used for list formatting. \u0020 represents a blank space | ||
| # Note that the trailing space is meaningful - "X, Y" vs. "X,Y" | ||
| listSeparator_middle =,\u0020 |
There was a problem hiding this comment.
Does this belong in date.properties?
There was a problem hiding this comment.
it should be in moz_intl.properties, but I wanted to avoid having to add moz_intl.properties and then ask developers to include both, or migrate eveyrthing from date.properties to moz_intl.properties and cause more work for localizers :( (also, migrating would require patching many apps).
So I just sticked to using date.properties for mozIntl.
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
3f7eb20 to
47108c5
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
47108c5 to
6a973db
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
6a973db to
332f08f
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
332f08f to
c34efbd
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
c34efbd to
cf04529
Compare
| @@ -140,7 +173,10 @@ | |||
| }, | |||
|
|
|||
| handleEvent: function(evt) { | |||
| const affectedObjects = resetObjects(evt.type); | |||
| // This is a temporary hack to help handling l10n.js' event | |||
| var type = evt.type === 'localized' ? 'DOMLocalized' : evt.type; | |||
There was a problem hiding this comment.
Nit: Also const? And remove blank lines?
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
cf04529 to
da3752f
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
da3752f to
1550b14
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
1550b14 to
bf7020f
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
bf7020f to
4a463df
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
4a463df to
702a3ec
Compare
zbraniecki
force-pushed
the
1207044-refactor-clock-l10n-and-intl
branch
from
702a3ec to
9cfe94b
Compare
…-and-intl Bug 1207044 - Refactor L10n/Intl in Clock to prepare for NGA. r=mcav
https://bugzilla.mozilla.org/show_bug.cgi?id=1207044