Fix gatsby 4 bug & bump peer dependency #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Gatsby 4 there's a "__GATSBY_IPFS_PATH_PREFIX__" in an error logging string that gets replaced in a way that breaks the string and causes an error. Not replacing the \"__GATSBY_IPFS_PATH_PREFIX__" if the " is escaped with \ fixes the issue
Now that the bug is fixed, gatsby-plugin-ipfs should be compatible with gatsby 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Gatsby 4 there's a "GATSBY_IPFS_PATH_PREFIX" in an error logging string that gets replaced in a way that breaks the string and causes an error.
That error is logged in the console as
Uncaught SyntaxError: missing ) after argument listThis is the (built & replaced) code that caused the error:
Not replacing the "GATSBY_IPFS_PATH_PREFIX" if the " is escaped with \ fixes the issue.
This is the (built & replaced) code after the fix is applied:
The fixed bug is mentioned in this issue: #25