Implement MIP-74 #992
Open
Implement MIP-74 #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primata
requested review from
l-monninger,
0xmovses,
mzabaluev and
musitdev
as code owners
apenzk
reviewed
Jan 10, 2025
apenzk
reviewed
Jan 10, 2025
| bytes32 public constant PAUSER_ROLE = keccak256(abi.encodePacked("PAUSER_ROLE")); | ||
|
|
||
| // Risk denominator must be above 3 | ||
| uint256 public constant RISK_DENOMINATOR_LOWER_BOUND = 3; |
There was a problem hiding this comment.
lower bound implies 3 is included, but you state "must be above 3", hence i modify to 4 below
apenzk
reviewed
Jan 10, 2025
apenzk
reviewed
Jan 10, 2025
| uint256 public constant MINIMUM_RISK_DENOMINATOR = 3; | ||
| bytes32 public constant PAUSER_ROLE = keccak256(abi.encodePacked("PAUSER_ROLE")); | ||
|
|
||
| // Risk denominator must be above 3 |
There was a problem hiding this comment.
Suggested change
| // Risk denominator must be above 3 | |
| // The riskDenominator determines the fraction of the insurance fund that can be used for the per day budget for a given transfer direction. | |
| // Risk denominator must be equal or above 4 |
apenzk
reviewed
Jan 10, 2025
apenzk
requested changes
Jan 10, 2025
There was a problem hiding this comment.
looks good for an initial approach apart from
- in the sol contract the risk_denominator cannot be updated. I am ok with this but it is inconsistent with the move contract equivalent
- requesting a few minor changes for acceptance.
long term, with more complex approaches like sliding window, we should consider the length of the window, but for now setting the window length to 1day is a good minimal approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-units,networks,scripts,util,cicd, ormisc.Implements MIP-74 specs
Changelog
adds outbound rate limit
adds PAUSER_ROLE
Testing
Outstanding issues