Docker Compose Enhancements #136
Conversation
README.md
Outdated
| When running with `docker compose` specif your revision in a file `.env` at the root of the project. The file should look like this: | ||
|
|
||
| ```bash | ||
| REV=0fe2a4f28820c04ca0db07cdd44cafc98b792f3f | ||
| ``` |
There was a problem hiding this comment.
Perhaps it's better to put this env file under ./docker/compose to make its purpose clear to somebody who stumbles upon it in the repository. Or if it must be in the root, clarify the variable's purpose like CONTAINER_REV.
There was a problem hiding this comment.
Referring to a container revision in the file that is under version control in the repository that is used to produce the container is going to be cumbersome. One consequence is that you could never have a clean tree that points docker-compose to use its current revision. Maybe the checked in .env file should be empty, or set some sensible default like latest?
There was a problem hiding this comment.
Right now, we don't have a latest flow for most delivery; we're pinning by commit hash. Doing it that way, while more cumbersome, is more deterministic. Perhaps semver to come.
We do have branch specific tags, if you look at the packages on this repo, you'll see them.
But, yes, eventually latest tags will be introduced for people just looking to play around.
There was a problem hiding this comment.
Perhaps it's better to put this env file under ./docker/compose to make its purpose clear to somebody who stumbles upon it in the repository. Or if it must be in the root, clarify the variable's purpose like CONTAINER_REV.
I think CONTAINER_REV makes the most sense to me. I will make the change.
…et's see if this fixes.
|
I believe what matters here is the underlying Docker Engine API: docker/compose#11680 So, I would essentially need to actually install Docker 26 on the runner |
| @@ -0,0 +1,57 @@ | |||
| pub(crate) trait BackendInternalOperations { | |||
There was a problem hiding this comment.
This looks out of place; an accidental commit from the Godfig work?
Summary
protocol-unitsSmall improvements to docker compose to include container testing.
Changelog
Testing