Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port version submodule of moveit_core #4

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Port version submodule of moveit_core #4

merged 1 commit into from
Feb 21, 2019

Conversation

vmayoral
Copy link
Contributor

No description provided.

v4hn
v4hn previously requested changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@v4hn v4hn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going back to constant install paths looks like a step back for me.

If ament does not support this any other way, wouldn't it be better to use GNUInstallDirs?

The same is true for most of the other open pull-requests right now.

@davetcoleman
Copy link
Member

@v4hn can you propose the exact code change you are requesting?

@mlautman
Copy link
Contributor

mlautman commented Feb 20, 2019 •
edited
Loading

This is standard across the entire ROS2 project. I am dismissing requested changes since it is more of a ROS2 design question which would be better to bring up with the OSRF team. I am happy to discuss further but I don't think we should hold up this PR while we debate the design of ROS2

@mlautman mlautman dismissed v4hn’s stale review February 20, 2019 23:08

see my comment above

@davetcoleman davetcoleman merged commit 43fc9bb into moveit:master Feb 21, 2019
rhaschke pushed a commit to rhaschke/moveit2 that referenced this pull request Dec 6, 2019
@JafarAbdi @henningkayser
Initial unit tests for MoveItCpp (moveit#4)
849e2fb
seanyen referenced this pull request in seanyen/moveit2 Jul 21, 2020
@lilustga
Merge pull request #4 from seanyen/seanyen/moveit_planners_ompl
434f8c7 
[moveit_planners_ompl] part 1
AndyZe referenced this pull request in AndyZe/moveit2 Sep 6, 2020
@ddengster
cleanup, revert dynamic reconfigure uncomment, fix parameter transfer…
6788e42 
… to controller_mgr_node

clang format fixes #3

compile and clang tidy fix

clang format fixes #4
@JeisonUR JeisonUR mentioned this pull request Mar 17, 2022
Closed
MikeWrock referenced this pull request in MikeWrock/moveit2 Aug 15, 2022
@nbbrooks @davetcoleman
Corrected tutorial's Cartesian path example (moveit#190)
47404fd 
* updated move_group_interface tutorial's Cartesian path waypoints (example #4) so path is triangular
* updated description of the path
MikeWrock referenced this pull request in MikeWrock/moveit2 Aug 15, 2022
@auman66
update cmake (#4)
f2606e6
@SmarkSauer SmarkSauer mentioned this pull request Nov 24, 2022
Closed
@swiz23 swiz23 mentioned this pull request Jan 5, 2023
Closed
@yeyanlei yeyanlei mentioned this pull request Apr 6, 2023
Closed
@robertokcanale robertokcanale mentioned this pull request Apr 26, 2023
Closed
This was referenced Jul 3, 2023
Closed
Closed
@patrickKXMD patrickKXMD mentioned this pull request Oct 19, 2023
Closed
@madgrizzle madgrizzle mentioned this pull request Nov 12, 2023
Closed
This was referenced Dec 23, 2023
Closed
Closed
@mergify Mergify
Copy link

mergify bot commented Mar 19, 2024

Please target the main branch for development, we will backport the changes to master for you if approved and if they don't break API.

@shrutic12 shrutic12 mentioned this pull request Apr 10, 2024
Closed
@xuanmumy xuanmumy mentioned this pull request May 26, 2024
Closed
@AnishNavalgund AnishNavalgund mentioned this pull request Jun 4, 2024
Closed
@Leopold-Klotz Leopold-Klotz mentioned this pull request Jun 27, 2024
Closed
@GraemeJf GraemeJf mentioned this pull request Jul 15, 2024
Closed
@patrickKXMD patrickKXMD mentioned this pull request Jan 4, 2025
Merged
6 tasks
This was referenced Jan 12, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlautman mlautman mlautman approved these changes

@davetcoleman davetcoleman davetcoleman approved these changes

@v4hn v4hn v4hn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vmayoral @davetcoleman @mlautman @v4hn