Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up hybrid planning package #2603

Merged
merged 17 commits into from
Jan 31, 2024
Merged

Clean-up hybrid planning package #2603

merged 17 commits into from
Jan 31, 2024

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Dec 13, 2023 •
edited
Loading

Description

  • Remove demo (will be added to moveit2_tutorials package)
  • Reactivate unittest
  • Resolve circular dependency in HP manager
  • Use generate param library to handle parameters

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sjahr sjahr requested a review from dyackzan December 13, 2023 11:53
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d16b4a) 51.18% compared to head (93b41e6) 50.73%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
- Coverage   51.18%   50.73%   -0.44%     
==========================================
  Files         393      392       -1     
  Lines       32753    32553     -200     
==========================================
- Hits        16760    16513     -247     
- Misses      15993    16040      +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify Mergify
Copy link

mergify bot commented Dec 13, 2023

This pull request is in conflict. Could you fix it @sjahr?

@sjahr
Remove demo from moveit repos
d35b983 
# Conflicts:
#	moveit_ros/hybrid_planning/test/hybrid_planning_demo_node.cpp
#	moveit_ros/hybrid_planning/test/launch/hybrid_planning_common.py
@sjahr
Re-enable launch test
4549ada
@sjahr
Migrate local planner to generate params library
1339a9a
@sjahr
Clean-up hp manager
e545129
@sjahr sjahr force-pushed the pr-clean_up_hybrid_planning branch from 65f0b85 to e545129 Compare January 19, 2024 11:05
@sjahr sjahr marked this pull request as ready for review January 19, 2024 11:18
@sjahr
Update moveit_ros/hybrid_planning/hybrid_planning_manager/hybrid_plan…
8358fdd 
…ning_manager_component/res/hp_manager_parameters.yaml
@sjahr sjahr requested a review from dyackzan January 22, 2024 16:53
@henningkayser henningkayser self-requested a review January 24, 2024 14:08
@sjahr sjahr mentioned this pull request Jan 25, 2024
Closed
6 tasks
henningkayser
henningkayser reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleanup looks really good! I left some suggestions about the parameters, otherwise lgtm

..._planning_manager_component/include/moveit/hybrid_planning_manager/hybrid_planning_manager.h Outdated Show resolved Hide resolved
...ng/hybrid_planning_manager/hybrid_planning_manager_component/src/hybrid_planning_manager.cpp Show resolved Hide resolved
...local_planner/local_planner_component/include/moveit/local_planner/local_planner_component.h Outdated Show resolved Hide resolved
moveit_ros/hybrid_planning/test/config/common_hybrid_planning_params.yaml Outdated Show resolved Hide resolved
@sjahr sjahr merged commit c19b1eb into moveit:main Jan 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningkayser henningkayser henningkayser approved these changes

@dyackzan dyackzan dyackzan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjahr @henningkayser @dyackzan