-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile on ROS2 Foxy #227
Compile on ROS2 Foxy #227
Conversation
0e280bd
to
38ee37b
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pulled the latest version here and successfully built/tested using the newest moveit2.repos
in a blank workspace. Looks good to me
59e966a
to
7aea7a7
Compare
c169983
to
6cab0ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update run_moveit_cpp.repos to use https://github.com/AdamPettinger/fake_joint/tree/foxy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor nits. I will now test this on foxy and report back if I have any issues making this work.
Travis succeeded, Github just doesn't get updated (https://travis-ci.com/github/ros-planning/moveit2/builds/179287457) |
Cleaned up redundant commits |
Once #226 is merged, I will branch off
foxy
and retarget this PR, generate docker images and trigger CI.