Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cautionary note about performance in get_row_count method #998

Merged
merged 3 commits into from
May 23, 2024
Merged

Add cautionary note about performance in get_row_count method #998

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57549fc
Add cautionary note about performance in get_row_count method
Feb 21, 2024
0856d1f
Merge branch 'main' into krausse-bq-getrowcount-docsupdate
matthewkrausse Feb 23, 2024
0b51b22
Merge branch 'main' into krausse-bq-getrowcount-docsupdate
shaunagm May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions parsons/google/google_bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,6 +1113,10 @@ def get_row_count(self, schema: str, table_name: str) -> int:
"""
Gets the row count for a BigQuery materialization.

Caution: This method uses SELECT COUNT(*) which can be expensive for large tables,
especially those with many columns. This is because BigQuery scans all table data
to perform the count, even though only the row count is returned.

`Args`:
schema: str
The schema name
Expand Down
Loading