Install dependencies for tests based on package install #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinweisgrau
force-pushed
the
tests-dependencies
branch
from
0140ceb
to
d1f9a98
Compare
Parsons dependencies can be installed in two different ways. `pip install -r requirements.txt` is equivalent to pip install parsons UNLESS the environment variable `PARSONS_LIMITED_DEPENDENCIES` is set, in which case the dependencies are installed based on the explicit configuration in `setup.py`. There can be drift between what is defined in requirements.txt and what is defined in `setup.py`. These changes ensure that both sets of dependencies are used to run tests, ensuring alignment between test environments and actual usage.
austinweisgrau
force-pushed
the
tests-dependencies
branch
from
d1f9a98
to
aa51976
Compare
IanRFerguson
approved these changes
Dec 8, 2023
|
My only concern about this is that it doubles the total number of tests, and might push us out of the free tier of Github actions. But we can always revisit if we run out of memory/minutes/compute/whatever-it-is-they-limit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsons dependencies can be installed in two different ways.
pip install -r requirements.txtis equivalent to pip install parsonsUNLESS the environment variable
PARSONS_LIMITED_DEPENDENCIESis set,in which case the dependencies are installed based on the explicit
configuration in
setup.py.There can be drift between what is defined in requirements.txt and
what is defined in
setup.py.These changes ensure that both sets of dependencies are used to run
tests, ensuring alignment between test environments and actual usage.
An example is tests passing on this PR even though the same tests would fail when using
PARSONS_LIMITED_DEPENDENCIES=1 pip install parsons[all](as explained and fixed in this PR)