Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the oauth_api_connector to accept authorization kwargs #918

Merged
merged 10 commits into from
Feb 20, 2024

Conversation

austinweisgrau
Copy link
Collaborator

@austinweisgrau austinweisgrau commented Nov 9, 2023

The oauth_api_connector can simplify authorization with APIs that use OAuth2, but requires some modifications to be general enough to work with different implementations of OAuth2.

This PR enables the use of authorization kwargs that are passed to authorization endpoints when requesting a token. The updated connector is then implemented in the Zoom connector as a test / demonstration.

Someone who has Zoom credentials should check if this update works.

Prior to this PR, the only connector that used the oauth_api_connector is the controlshift connector. That one should be unaffected, because the new argument is optional and doesn't change behavior if it is not used.

This should be tested by folks who have credentials with all three directly affected connectors:

  • Catalist Match
  • Zoom
  • Controlshift

@austinweisgrau
Copy link
Collaborator Author

Rebasing onto main and adding a commit that updates the catalist match connector to also use the oauth_api_connector

@austinweisgrau
Copy link
Collaborator Author

This is verified to work with the Catalist Match connector

@shaunagm
Copy link
Collaborator

This works on Zoom! Checked the checkbox - now we just need ControlShift tested and we'll be good to merge.

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this out on Zoom and per Austin it works for Catalist and ControlShift.

@shaunagm shaunagm merged commit 617d06f into move-coop:main Feb 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants