Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action Builder Entity Record Insert Name Key Hotfix #887

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Action Builder Entity Record Insert Name Key Hotfix #887

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d6a158
allow for bldr prefix on name key when inserting records
ydamit Sep 6, 2023
8803d09
linted
ydamit Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions parsons/action_builder/action_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,11 @@ def insert_entity_record(self, entity_type, data=None, campaign=None):
Dict containing Action Builder entity data.
""" # noqa: E501

name_keys = ("name", "action_builder:name", "given_name")
error = "Must provide data with name or given_name when inserting new record"
if not isinstance(data, dict):
raise ValueError(error)
name_check = [
key for key in data.get("person", {}) if key in ("name", "given_name")
]
name_check = [key for key in data.get("person", {}) if key in name_keys]
if not name_check:
raise ValueError(error)

Expand Down