Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of "extension" argument to Redshift unload #871

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

austinweisgrau
Copy link
Collaborator

Extension is a helpful argument. This PR makes it possible to use the extension argument on Redshift.unload()

I have a workflow where I unload SQL query to S3, and then make the resulting file available to download. It's great if that file already has a proper extension and I don't need to rename the file in S3 first. Currently all Redshift.unload() files have an extension of .gz if the file is compressed or simply ends with 000 if not.

Copy link
Contributor

@jafayer jafayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change lgtm, can pass off to @shaunagm for a double-check!

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me too!

@shaunagm shaunagm merged commit b6f9dd8 into move-coop:main Sep 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants