-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NewMode - Add bulk targets
endpoint
#857
Conversation
@ydamit looks like there might be some linting / formatting errors from the action builder connector. Would you mind taking a look at that so we can get the build to run here? |
@willyraedy , I'll do my best! Am I using criteria from black or flake8? |
If you click the "Details" link in the build step above, it should show you the errors. |
If you update your branch, it should get rid of those linting errors since they've been fixed on |
@willyraedy , gotcha. So it sounds like we're just moving over to black, since it looks like part of the issue is that some of the docstrings that go long are decorated with |
Oh nevermind, then! |
@IanRFerguson did you see that? Sounds like you just need to re-merge latest from main here |
Merging main to handle linter conflicts in past merges
@shaunagm @willyraedy Checks passing! ready for another look when y'all have time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds an additional
GET
request to the NewMode client that allows ALL targets to be queried and returned as a table. The addition of this function will give Parsons users flexibility in their API requests to NewMode, as they may be interested in exploring target data broadly and across outreaches.