Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewMode - Add bulk targets endpoint #857

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

IanRFerguson
Copy link
Contributor

@IanRFerguson IanRFerguson commented Jul 17, 2023

This PR adds an additional GET request to the NewMode client that allows ALL targets to be queried and returned as a table. The addition of this function will give Parsons users flexibility in their API requests to NewMode, as they may be interested in exploring target data broadly and across outreaches.


@IanRFerguson IanRFerguson added low priority Priority - this is a nice-to-have, is non-urgent, and/or has a minor overall imapact on Parsons connector update Work type - additions or changes to the functions of an existing Parsons connector labels Jul 17, 2023
@IanRFerguson IanRFerguson self-assigned this Jul 17, 2023
@elyse-weiss elyse-weiss removed their request for review July 17, 2023 16:21
@willyraedy
Copy link
Contributor

@ydamit looks like there might be some linting / formatting errors from the action builder connector. Would you mind taking a look at that so we can get the build to run here?

@ydamit
Copy link
Contributor

ydamit commented Jul 24, 2023

@willyraedy , I'll do my best! Am I using criteria from black or flake8?

@willyraedy
Copy link
Contributor

@willyraedy , I'll do my best! Am I using criteria from black or flake8?

If you click the "Details" link in the build step above, it should show you the errors.

image

@shaunagm
Copy link
Collaborator

If you update your branch, it should get rid of those linting errors since they've been fixed on main as of this morning.

@ydamit
Copy link
Contributor

ydamit commented Jul 24, 2023

@willyraedy , gotcha. So it sounds like we're just moving over to black, since it looks like part of the issue is that some of the docstrings that go long are decorated with noqa for flake8 purposes, but black doesn't seem to like that?

@ydamit
Copy link
Contributor

ydamit commented Jul 24, 2023

Oh nevermind, then!

@willyraedy
Copy link
Contributor

@IanRFerguson did you see that? Sounds like you just need to re-merge latest from main here

Merging main to handle linter conflicts in past merges
@IanRFerguson
Copy link
Contributor Author

@shaunagm @willyraedy Checks passing! ready for another look when y'all have time

Copy link
Contributor

@willyraedy willyraedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IanRFerguson IanRFerguson merged commit 16884a9 into main Jul 27, 2023
1 check passed
@IanRFerguson IanRFerguson deleted the ianferguson-newmode-targets-endpoint branch July 27, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector update Work type - additions or changes to the functions of an existing Parsons connector low priority Priority - this is a nice-to-have, is non-urgent, and/or has a minor overall imapact on Parsons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants