Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/background processing #853

Merged
merged 9 commits into from
Jul 24, 2023

Conversation

talevy42
Copy link
Contributor

@talevy42 talevy42 commented Jul 8, 2023

Adds an optional argument to use ActionNetwork's background processing feature: https://actionnetwork.org/docs/v2/#background-processing

@talevy42 talevy42 force-pushed the feature/background-processing branch from 27b0028 to 65db58a Compare July 8, 2023 01:05
@talevy42 talevy42 force-pushed the feature/background-processing branch from 65db58a to 517b7ec Compare July 8, 2023 01:07
@sharinetmc
Copy link
Contributor

Hi @tal42levy! There seems to be an issue with linting. Perhaps if you run black on this, it should definitely resolve itself.

@talevy42
Copy link
Contributor Author

That's really weird – black isn't changing anything for me

Copy link
Contributor

@sharinetmc sharinetmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing status to request changes!

@talevy42
Copy link
Contributor Author

Black does change tests, but not action_builder – which as a note, the docs on linting don't include linting test/

@sharinetmc
Copy link
Contributor

Thanks for letting me know! I bump Shauna on this, so waiting on her input!

@talevy42
Copy link
Contributor Author

Ah oops - my comment was on the wrong the MR. I linted this one successfully, I think.

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing the action builder linting problem along the way :)

@shaunagm shaunagm dismissed sharinetmc’s stale review July 24, 2023 18:18

linting was fixed

@shaunagm shaunagm merged commit 13b82a8 into move-coop:main Jul 24, 2023
1 check passed
@sharinetmc sharinetmc added the connector update Work type - additions or changes to the functions of an existing Parsons connector label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector update Work type - additions or changes to the functions of an existing Parsons connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants