Add json as allowable file type to copy_s3 #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunagm
previously approved these changes
Jun 22, 2023
|
My test case failed because it's line delimited JSON, which Redshift can't handle because Redshift is a big baby, so I'll test this as soon as I can find a better test case |
shaunagm
dismissed
their stale review
this needs changes and so I want to get the state of the PR correct
|
Ok, this branch has now been tested VERY thoroughly, our Hustle sync is actively running on this branch, so I'm confident it's ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add json as allowable file type to copy_s3. Since it's converting to a Parsons table, should be no downstream effects.