-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json as allowable file type to copy_s3 #844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, though I haven't tested it. You should merge if/when you feel it's ready.
My test case failed because it's line delimited JSON, which Redshift can't handle because Redshift is a big baby, so I'll test this as soon as I can find a better test case |
this needs changes and so I want to get the state of the PR correct
Ok, this branch has now been tested VERY thoroughly, our Hustle sync is actively running on this branch, so I'm confident it's ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add json as allowable file type to copy_s3. Since it's converting to a Parsons table, should be no downstream effects.