Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exists_ok param to add_column #839

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

talevy42
Copy link
Contributor

@talevy42 talevy42 commented Jun 8, 2023

No description provided.

parsons/etl/etl.py Outdated Show resolved Hide resolved
parsons/etl/etl.py Outdated Show resolved Hide resolved
@shaunagm
Copy link
Collaborator

shaunagm commented Jun 16, 2023

In addition to the parameter rename, you'll also need to lint the contribution. The new docs that show you how to do it are finally live! Sorry that they were missing before. You can see the instructions here: https://move-coop.github.io/parsons/html/stable/contributing.html#linting

Running Black locally and committing the changes should fix any issues.

@shaunagm
Copy link
Collaborator

Can you see the test results? If not, here they are:

=================================== FAILURES ===================================
__________________ TestParsonsTable.test_add_column_exists_ok __________________

self = <test.test_etl.TestParsonsTable testMethod=test_add_column_exists_ok>

    def test_add_column_exists_ok(self):
>       self.tbl.add_column("first", exists_ok=True)
E       TypeError: ETL.add_column() got an unexpected keyword argument 'exists_ok'

test/test_etl.py:309: TypeError
=============================== warnings summary ===============================
venv/lib/python3.10/site-packages/joblib/my_exceptions.py:21
  /home/circleci/repo/venv/lib/python3.10/site-packages/joblib/my_exceptions.py:21: DeprecationWarning: TransportableException is deprecated and will be removed from joblib in 0.16
    warn("{} is deprecated and will be removed from joblib "

test/test_etl.py::TestParsonsTable::test_from_petl
test/test_etl.py::TestParsonsTable::test_from_petl
test/test_etl.py::TestParsonsTable::test_from_petl
  /home/circleci/repo/venv/lib/python3.10/site-packages/petl/util/random.py:170: DeprecationWarning: Seeding based on hashing is deprecated
  since Python 3.9 and will be removed in a subsequent version. The only 
  supported seed types are: None, int, float, str, bytes, and bytearray.
    random.seed(seed)

test/test_gmail/test_gmail.py: 10 warnings
  /home/circleci/repo/venv/lib/python3.10/site-packages/httplib2/__init__.py:147: DeprecationWarning: ssl.PROTOCOL_TLS is deprecated
    context = ssl.SSLContext(DEFAULT_TLS_VERSION)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED test/test_etl.py::TestParsonsTable::test_add_column_exists_ok - TypeEr...
===== 1 failed, 667 passed, 182 skipped, 1 xfailed, 14 warnings in 22.65s ======

Exited with code exit status 1

CircleCI received exit code 1
`

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the variable name changes! This looks ready to merge.

@shaunagm shaunagm merged commit e7f1e94 into move-coop:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants