Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid setup.py syntax #831

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

crayolakat
Copy link
Collaborator

After c056045 was merged, there is an error when running: pip install git+https://github.com/move-coop/parsons@main#egg=parsons

(test-pywell-ve) kathynguyen@administrators-MacBook-Pro-2 test-pywell % pip install git+https://github.com/move-coop/parsons@main#egg=parsons
Collecting parsons
  Cloning https://github.com/move-coop/parsons (to revision main) to /private/var/folders/d4/td5jnc7d6zd6s1ylg1t74jn40000gp/T/pip-install-2424vdzk/parsons_7b331d3cb8aa43a789e103429d496a28
  Running command git clone --filter=blob:none --quiet https://github.com/move-coop/parsons /private/var/folders/d4/td5jnc7d6zd6s1ylg1t74jn40000gp/T/pip-install-2424vdzk/parsons_7b331d3cb8aa43a789e103429d496a28
  Resolved https://github.com/move-coop/parsons to commit 9e061ba7c314be03025b4fa702cd76a00c50773a
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      error in parsons setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers.
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

This is because ~= is not valid syntax in setup.py. I changed it to <2, which is valid.

@crayolakat crayolakat requested a review from shaunagm June 6, 2023 00:25
@crayolakat
Copy link
Collaborator Author

Also tagging @cmc333333 for visibility, although I am not able to add you as a reviewer to this PR for some reason!

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaunagm shaunagm merged commit f1ac0c5 into move-coop:main Jun 6, 2023
@cmc333333
Copy link
Contributor

Whoops, sorry about the incorrect syntax @crayolakat !

talevy42 pushed a commit to talevy42/parsons that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants